Fixes #5362: MainThreadTextEditor: disassociate code editor as soon as code editor's model changes

build/gulpfile.hygiene.js

@@ -55,7 +55,8 @@ var indentationFilter = [
 	'!extensions/**/snippets/**',
 	'!extensions/**/syntaxes/**',
 	'!extensions/**/themes/**',
-	'!extensions/**/colorize-fixtures/**'
+	'!extensions/**/colorize-fixtures/**',
+	'!extensions/vscode-api-tests/testWorkspace/**'
 ];
 
 var copyrightFilter = [

extensions/vscode-api-tests/src/window.test.ts

@@ -6,7 +6,7 @@
 'use strict';
 
 import * as assert from 'assert';
-import {workspace, window, ViewColumn, TextEditorViewColumnChangeEvent, Uri} from 'vscode';
+import {workspace, window, ViewColumn, TextEditorViewColumnChangeEvent, Uri, Selection, Position} from 'vscode';
 import {join} from 'path';
 import {cleanUp, pathEquals} from './utils';
 
@@ -82,4 +82,68 @@ suite('window namespace tests', () => {
 			});
 		});
 	});
-});
\ No newline at end of file
+
+	test('issue #5362 - Incorrect TextEditor passed by onDidChangeTextEditorSelection', (done) => {
+		const file10Path = join(workspace.rootPath, './10linefile.ts');
+		const file30Path = join(workspace.rootPath, './30linefile.ts');
+
+		let finished = false;
+		let failOncePlease = (err:Error) => {
+			if (finished) {
+				return;
+			}
+			finished = true;
+			done(err);
+		};
+
+		let passOncePlease = () => {
+			if (finished) {
+				return;
+			}
+			finished = true;
+			done(null);
+		};
+
+		let subscription = window.onDidChangeTextEditorSelection((e) => {
+			let lineCount = e.textEditor.document.lineCount;
+			let pos1 = e.textEditor.selections[0].active.line;
+			let pos2 = e.selections[0].active.line;
+
+			if (pos1 !== pos2) {
+				failOncePlease(new Error('received invalid selection changed event!'));
+				return;
+			}
+
+			if (pos1 >= lineCount) {
+				failOncePlease(new Error(`Cursor position (${pos1}) is not valid in the document ${e.textEditor.document.fileName} that has ${lineCount} lines.`));
+				return;
+			}
+		});
+
+		// Open 10 line file, show it in slot 1, set cursor to line 10
+		// Open 30 line file, show it in slot 1, set cursor to line 30
+		// Open 10 line file, show it in slot 1
+		// Open 30 line file, show it in slot 1
+		workspace.openTextDocument(file10Path).then((doc) => {
+			return window.showTextDocument(doc, ViewColumn.One);
+		}).then((editor10line) => {
+			editor10line.selection = new Selection(new Position(9,0), new Position(9, 0));
+		}).then(() => {
+			return workspace.openTextDocument(file30Path);
+		}).then((doc) => {
+			return window.showTextDocument(doc, ViewColumn.One);
+		}).then((editor30line) => {
+			editor30line.selection = new Selection(new Position(29,0), new Position(29, 0));
+		}).then(() => {
+			return workspace.openTextDocument(file10Path);
+		}).then((doc) => {
+			return window.showTextDocument(doc, ViewColumn.One);
+		}).then(() => {
+			return workspace.openTextDocument(file30Path);
+		}).then((doc) => {
+			return window.showTextDocument(doc, ViewColumn.One);
+		}).then(() => {
+			subscription.dispose();
+		}).then(passOncePlease, failOncePlease);
+	});
+});

extensions/vscode-api-tests/testWorkspace/10linefile.ts

+function foo(): void {
+    var a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+}
\ No newline at end of file

extensions/vscode-api-tests/testWorkspace/30linefile.ts

+function bar(): void {
+    var a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+    a = 1;
+}
\ No newline at end of file

src/vs/workbench/api/node/mainThreadEditors.ts

@@ -126,6 +126,11 @@ export class MainThreadTextEditor {
 		this._codeEditor = codeEditor;
 		if (this._codeEditor) {
 
+			// Catch early the case that this code editor gets a different model set and disassociate from this model
+			this._codeEditorListeners.push(this._codeEditor.addListener2(EditorCommon.EventType.ModelChanged, () => {
+				this.setCodeEditor(null);
+			}));
+
 			let forwardSelection = () => {
 				this._lastSelection = this._codeEditor.getSelections();
 				this._onSelectionChanged.fire(this._lastSelection);