CONTRIBUTING 3.3 KB
Newer Older
R
Rich Salz 已提交
1 2
HOW TO CONTRIBUTE TO PATCHES OpenSSL
------------------------------------
3

M
Matt Caswell 已提交
4
(Please visit https://www.openssl.org/community/getting-started.html for
R
Rich Salz 已提交
5
other ideas about how to contribute.)
6

R
Rich Salz 已提交
7
Development is coordinated on the openssl-dev mailing list (see the
M
Matt Caswell 已提交
8
above link or https://mta.openssl.org for information on subscribing).
9
If you are unsure as to whether a feature will be useful for the general
R
Rich Salz 已提交
10 11 12
OpenSSL community you might want to discuss it on the openssl-dev mailing
list first.  Someone may be already working on the same thing or there
may be a good reason as to why that feature isn't implemented.
13

R
Rich Salz 已提交
14 15 16 17
The best way to submit a patch is to make a pull request on GitHub.
(It is not necessary to send mail to rt@openssl.org to open a ticket!)
If you think the patch could use feedback from the community, please
start a thread on openssl-dev.
R
Rich Salz 已提交
18

M
Matt Caswell 已提交
19
You can also submit patches by sending it as mail to rt@openssl.org.
R
Rich Salz 已提交
20 21 22 23
Please include the word "PATCH" and an explanation of what the patch
does in the subject line.  If you do this, our preferred format is "git
format-patch" output. For example to provide a patch file containing the
last commit in your local git repository use the following command:
24

R
Rich Salz 已提交
25
    % git format-patch --stdout HEAD^ >mydiffs.patch
26 27 28

Another method of creating an acceptable patch file without using git is as
follows:
29

R
Rich Salz 已提交
30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
    % cd openssl-work
    ...make your changes...
    % ./Configure dist; make clean
    % cd ..
    % diff -ur openssl-orig openssl-work >mydiffs.patch

Note that pull requests are generally easier for the team, and community, to
work with.  Pull requests benefit from all of the standard GitHub features,
including code review tools, simpler integration, and CI build support.

No matter how a patch is submitted, the following items will help make
the acceptance and review process faster:

    1. Anything other than trivial contributions will require a contributor
    licensing agreement, giving us permission to use your code. See
M
Matt Caswell 已提交
45
    https://www.openssl.org/policies/cla.html for details.
R
Rich Salz 已提交
46 47 48 49 50 51 52 53 54 55 56 57 58

    2.  All source files should start with the following text (with
    appropriate comment characters at the start of each line and the
    year(s) updated):

        Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved.

        Licensed under the OpenSSL license (the "License").  You may not use
        this file except in compliance with the License.  You can obtain a copy
        in the file LICENSE in the source distribution or at
        https://www.openssl.org/source/license.html

    3.  Patches should be as current as possible.  When using GitHub, please
M
Matt Caswell 已提交
59 60 61
    expect to have to rebase and update often. Note that we do not accept merge
    commits, so please avoid these in any pull request. You will be asked to
    remove them before a patch is considered acceptable.
R
Rich Salz 已提交
62

M
Matt Caswell 已提交
63
    4.  Patches should follow our coding style (see
R
Rich Salz 已提交
64
    https://www.openssl.org/policies/codingstyle.html) and compile without
M
Matt Caswell 已提交
65 66 67
    warnings. Where gcc or clang is availble you should use the
    --strict-warnings Configure option.  OpenSSL compiles on many varied
    platforms: try to ensure you only use portable features.
R
Rich Salz 已提交
68

M
Matt Caswell 已提交
69
    5.  When at all possible, patches should include tests. These can either be
R
Rich Salz 已提交
70 71
    added to an existing test, or completely new.  Please see test/README
    for information on the test framework.