README.md 20.0 KB
Newer Older
P
Phodal Huang 已提交
1
# Coca - toolbox for system refactoring and analysis
P
Phodal HUANG 已提交
2

P
Phodal Huang 已提交
3
[![Build Status](https://travis-ci.org/phodal/coca.svg?branch=master)](https://travis-ci.org/phodal/coca)
P
Phodal Huang 已提交
4 5
[![Maintainability](https://api.codeclimate.com/v1/badges/d5a5e060522403b1f79b/maintainability)](https://codeclimate.com/github/phodal/coca/maintainability)
[![codecov](https://codecov.io/gh/phodal/coca/branch/master/graph/badge.svg)](https://codecov.io/gh/phodal/coca)
P
Phodal Huang 已提交
6

P
Phodal Huang 已提交
7
> Coca is a toolbox which is design for legacy system refactoring. Coca 是一个用于系统重构、系统迁移和系统分析的瑞士军刀。它可以分析代码中的 badsmell,行数统计,分析调用与依赖,进行 Git 分析,以及自动化重构等。
P
Phodal Huang 已提交
8

P
Phodal Huang 已提交
9
Refactoring Modeling:
P
Phodal Huang 已提交
10

P
Phodal Huang 已提交
11
![Refactoring Modeling](docs/images/model.svg)
P
Phodal Huang 已提交
12

P
Phodal Huang 已提交
13 14 15 16
## Usage

install 

P
Phodal Huang 已提交
17
```bash
P
Phodal Huang 已提交
18
go get -u github.com/phodal/coca
P
Phodal Huang 已提交
19 20
```

P
Phodal Huang 已提交
21 22
help:

P
Phodal Huang 已提交
23
```bash
P
Phodal Huang 已提交
24 25 26
Usage:
  coca [command]

P
Phodal Huang 已提交
27

P
Phodal Huang 已提交
28 29 30
Available Commands:
  analysis    analysis package
  api         scan api
P
Phodal Huang 已提交
31
  bs          bad smell analysis
P
Phodal Huang 已提交
32
  call        call graph api
P
Phodal Huang 已提交
33
  cloc        cloc [FILE or DIRECTORY]
P
Phodal Huang 已提交
34
  concept     concept api
P
Phodal Huang 已提交
35
  count       count code
P
Phodal Huang 已提交
36
  evaluate    evaluate refactor effort
P
Phodal Huang 已提交
37
  git         git analysis
P
Phodal Huang 已提交
38
  help        Help about any command
P
Phodal Huang 已提交
39
  rcall       reverse call
P
Phodal Huang 已提交
40
  refactor    auto refactor code
P
Phodal Huang 已提交
41 42 43 44
  suggest     simple holmes
  todo        scan todo
  version     print the version number of Coca

P
Phodal Huang 已提交
45

P
Phodal Huang 已提交
46 47
```

P
Phodal Huang 已提交
48 49 50
1. Run `coca analysis`
2. Run Command

P
Phodal Huang 已提交
51
### Analysis
P
Phodal Huang 已提交
52 53

```
P
Phodal Huang 已提交
54
coca analysis
P
Phodal Huang 已提交
55 56
```

P
Phodal Huang 已提交
57 58 59 60 61 62
### Arch

```
coca arch
```

P
Phodal Huang 已提交
63 64 65 66 67 68 69
Examples Results 1:

![Architecture demo 2](docs/sample/ddd.svg)

from: [https://github.com/newlee/tequila](https://github.com/newlee/tequila/tree/master/examples/step2-Java)

Examples Results 2:
P
Phodal Huang 已提交
70 71 72

![Architecture demo](docs/sample/arch.svg)

P
Phodal Huang 已提交
73
from: [https://github.com/howiehu/ddd-architecture-samples](https://github.com/howiehu/ddd-architecture-samples)
P
Phodal Huang 已提交
74

P
Phodal Huang 已提交
75 76
### Find Bad Smells

P
Phodal Huang 已提交
77
```bash
P
Phodal Huang 已提交
78
coca bs -s type
P
Phodal Huang 已提交
79 80
```

P
Phodal Huang 已提交
81 82
Examples Result:

P
Phodal Huang 已提交
83
```json
P
Phodal Huang 已提交
84
{
P
Phodal Huang 已提交
85 86 87 88 89 90 91 92 93 94 95 96
   "dataClass": [
      {
         "File": "examples/api/BookController.java",
         "BS": "dataClass"
      }
   ],
   "lazyElement": [
      {
         "File": "examples/api/model/BookRepresentaion.java",
         "BS": "lazyElement"
      }
   ]
P
Phodal Huang 已提交
97 98 99
}
```

P
Phodal Huang 已提交
100 101 102
### Code Line Count

```
P
Phodal Huang 已提交
103
coca cloc
P
Phodal Huang 已提交
104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
```

Results:

```
───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Go                          58     31763     7132       890    23741       2847
Java                        44       971      208        21      742         62
Markdown                     8       238       75         0      163          0
Gherkin Specificati…         2        32        2        16       14          0
Document Type Defin…         1       293       36         0      257          0
License                      1       201       32         0      169          0
SQL                          1         2        0         0        2          0
SVG                          1       199        0        34      165          0
Shell                        1         3        1         1        1          0
XML                          1        13        0         0       13          0
gitignore                    1        61        8         4       49          0
───────────────────────────────────────────────────────────────────────────────
Total                      119     33776     7494       966    25316       2909
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop $803,822
Estimated Schedule Effort 14.120551 months
Estimated People Required 6.743156
P
Phodal Huang 已提交
129
───────────────────────────────────────────────────────────────────────────────
P
Phodal Huang 已提交
130 131
```

P
Phodal Huang 已提交
132 133 134 135 136 137
Results to json

```
coca cloc --by-file --format json
```

P
Phodal Huang 已提交
138 139 140
### Build Deps Tree

```
P
Phodal Huang 已提交
141
coca call -c com.phodal.pholedge.book.BookController.createBook -r com.phodal.pholedge.
P
Phodal Huang 已提交
142 143
```

P
Phodal Huang 已提交
144 145
Examples Results:

P
Phodal Huang 已提交
146 147 148 149 150
![Call Demo](docs/sample/call_demo.svg)

### Identify Spring API

```
P
Phodal Huang 已提交
151
coca api -f
P
Phodal Huang 已提交
152 153
```

P
Phodal Huang 已提交
154 155
![API Demo](docs/sample/api.svg)

P
Phodal Huang 已提交
156 157 158
With Count

```
P
Phodal Huang 已提交
159
coca api -r com.phodal.pholedge. -c 
P
Phodal Huang 已提交
160 161
``` 

P
Phodal Huang 已提交
162 163
or multi package:

P
Phodal Huang 已提交
164
`coca api  -r com.macro.mall.demo.controller.,com.zheng.cms.admin.,com.phodal.pholedge -c` 
P
Phodal Huang 已提交
165

P
Phodal Huang 已提交
166
```bash
P
Phodal Huang 已提交
167 168 169 170 171 172 173 174 175 176 177 178 179
+------+--------+------------------------------------------------+------------------------------------------------------------------------+
| SIZE | METHOD |                      URI                       |                                 CALLER                                 |
+------+--------+------------------------------------------------+------------------------------------------------------------------------+
|   36 | GET    | /aliyun/oss/policy                             | controller.OssController.policy                                        |
|   21 | POST   | /aliyun/osscallback                            | controller.OssController.callback                                      |
|   17 | GET    | /subject/list                                  | controller.CmsSubjectController.getList                                |
|   17 | GET    | /esProduct/search                              | search.controller.EsProductController.search                           |
|   17 | GET    | /order/list                                    | controller.OmsOrderController.list                                     |
|   17 | GET    | /productAttribute/list/{cid}                   | controller.PmsProductAttributeController.getList                       |
|   17 | GET    | /productCategory/list/{parentId}               | controller.PmsProductCategoryController.getList                        |
|   17 | GET    | /brand/list                                    | controller.PmsBrandController.getList                                  |
|   17 | GET    | /esProduct/search/simple                       | search.controller.EsProductController.search                           |
+------+--------+------------------------------------------------+------------------------------------------------------------------------+
P
Phodal Huang 已提交
180 181
```

P
Phodal Huang 已提交
182 183 184
### Git Analysis

```
P
Phodal Huang 已提交
185
coca git -t
P
Phodal Huang 已提交
186 187
```

P
Phodal Huang 已提交
188 189 190
Results: 

```bash
P
Phodal Huang 已提交
191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
+---------------------------------------------------------------------------------------------------------------------+-----------+-------------+
|                                                     ENTITYNAME                                                      | REVSCOUNT | AUTHORCOUNT |
+---------------------------------------------------------------------------------------------------------------------+-----------+-------------+
| build.gradle                                                                                                        |      1326 |          36 |
| src/asciidoc/index.adoc                                                                                             |       239 |          20 |
| build-spring-framework/resources/changelog.txt                                                                      |       187 |          10 |
| spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java                                  |       170 |          10 |
| spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java                |       159 |          15 |
| src/docs/asciidoc/web/webmvc.adoc                                                                                   |       121 |          24 |
| spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java                   |       118 |           9 |
| src/dist/changelog.txt                                                                                              |       118 |           9 |
| spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupport.java       |       116 |          15 |
| spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java        |       113 |          15 |
| spring-web/src/main/java/org/springframework/http/HttpHeaders.java                                                  |       111 |          18 |
| src/docs/asciidoc/web/webflux.adoc                                                                                  |       108 |          21 |
| spring-core/src/main/java/org/springframework/core/annotation/AnnotatedElementUtils.java                            |       107 |           9 |
| spring-test/spring-test.gradle                                                                                      |       105 |           7 |
| spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java |       105 |          13 |
| spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java         |       101 |          12 |
| spring-web/src/main/java/org/springframework/web/client/RestTemplate.java                                           |        98 |          17 |
| spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java                |        96 |          14 |
| org.springframework.core/src/main/java/org/springframework/core/convert/TypeDescriptor.java                         |        93 |           4 |
| spring-core/src/main/java/org/springframework/core/ResolvableType.java                                              |        92 |          10 |
+---------------------------------------------------------------------------------------------------------------------+-----------+-------------+
P
Phodal Huang 已提交
215 216
```

P
Phodal Huang 已提交
217 218 219
### Concept Analyser

```
P
Phodal Huang 已提交
220
coca concept
P
Phodal Huang 已提交
221 222 223 224 225
```

Results Examples:

```
P
Phodal Huang 已提交
226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
+------------------+--------+
|      WORDS       | COUNTS |
+------------------+--------+
| context          |    590 |
| resolve          |    531 |
| path             |    501 |
| content          |    423 |
| code             |    416 |
| resource         |    373 |
| property         |    372 |
| session          |    364 |
| attribute        |    349 |
| properties       |    343 |
| headers          |    330 |
+------------------+--------+
P
Phodal Huang 已提交
241 242
```

P
Phodal Huang 已提交
243 244 245
### Count Refs

```
P
Phodal Huang 已提交
246
coca count
P
Phodal Huang 已提交
247 248 249 250 251
```

Results:

```
P
Phodal Huang 已提交
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274
+------------+--------------------------------------------------------------------------+
| REFS COUNT |                                  METHOD                                  |
+------------+--------------------------------------------------------------------------+
|          2 | com.phodal.pholedge.book.BookRepository.byId                             |
|          2 | com.phodal.pholedge.book.model.Book.toRepresentation                     |
|          2 | com.phodal.pholedge.book.BookRepository.save                             |
|          2 | com.phodal.coca.analysis.JavaCallApp.parse                               |
|          2 | com.phodal.pholedge.book.BookRepository.save                             |
|          2 | com.phodal.coca.analysis.JavaCallApp.parse                               |
|          1 | com.phodal.pholedge.book.model.Book.save                                 |
|          1 | evolution.analysis.jv.calls.JavaCallVisitor.parseNewType                 |
|          1 | evolution.analysis.jv.calls.JavaCallVisitor.isNotSpecialNewWord          |
|          1 | com.phodal.pholedge.book.BookMapper.byId                                 |
|          1 | com.phodal.pholedge.book.BookService.updateBook                          |
|          1 | com.phodal.pholedge.book.BookService.getBooksLists                       |
|          1 | com.phodal.pholedge.book.BookService.getBookById                         |
|          1 | com.phodal.pholedge.book.BookMapper.doSave                               |
|          1 | com.phodal.pholedge.book.BookMapper.list                                 |
|          1 | com.phodal.pholedge.book.BookService.createBook                          |
|          1 | com.phodal.pholedge.book.BookFactory.create                              |
|          1 | com.phodal.pholedge.book.BookRepository.list                             |
|          1 | com.phodal.pholedge.book.model.Book.create                               |
+------------+--------------------------------------------------------------------------+
P
Phodal Huang 已提交
275 276
```

P
Phodal Huang 已提交
277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
### Reverse Call Graph

```
coca rcall -c org.bytedeco.javacpp.tools.TokenIndexer.get
```

Results:

```
digraph G { 
edge [dir="back"];

"org.bytedeco.javacpp.tools.Parser.extern" -> "org.bytedeco.javacpp.tools.Parser.declarations";
"org.bytedeco.javacpp.tools.Parser.declarations" -> "org.bytedeco.javacpp.tools.Parser.extern";
...
}
```

![RCall Demo](docs/sample/rcall.svg)

P
Phodal Huang 已提交
297
### Auto Refactor
P
Phodal Huang 已提交
298 299 300 301 302 303 304

support: 

 - rename
 - move
 - remove unused import
 - remove unused class
P
Phodal Huang 已提交
305 306

```
P
Phodal Huang 已提交
307
coca refactor -R rename.coca -p src/main
P
Phodal Huang 已提交
308 309 310
coca refactor -m move.config -p .
```

P
Phodal Huang 已提交
311 312 313 314 315 316 317
### Evaluate

```
coca evaluate
```

```
P
Phodal Huang 已提交
318 319 320 321 322 323 324 325 326 327 328
+--------------------------------+-------+-----------------------+-------+-----------+
|              TYPE              | COUNT |         LEVEL         | TOTAL |   RATE    |
+--------------------------------+-------+-----------------------+-------+-----------+
| Nullable / Return Null         |     0 | Method                |  5256 | 0.00%     |
| Utils                          |    18 | Class                 |   366 | 4.92%     |
| Static Method                  |     0 | Method                |  5256 | 0.34%     |
| Average Method Num.            |  5256 | Method/Class          |   366 | 14.360656 |
| Method Num. Std Dev / 标准差   |  5256 | Class                 | -     | 32.965336 |
| Average Method Length          | 19644 | Without Getter/Setter |  4328 |  4.538817 |
| Method Length Std Dev / 标准差 |  5256 | Method                | -     |  4.467935 |
+--------------------------------+-------+-----------------------+-------+-----------+
P
Phodal Huang 已提交
329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364
```

Evaluate.json examples

```json
{
	"Nullable": {
		"Items": [
			"nonnull.Name.testNull",
			"nonnull.Name.orElseNull",
			"org.ofbiz.base.util.UtilURL.fromResource",
			"org.ofbiz.base.util.UtilURL.getOfbizHomeRelativeLocationFromFilePath",
			"study.huhao.demo.adapters.outbound.persistence.blog.BlogPO.toDomainModel",
			"study.huhao.demo.adapters.outbound.persistence.blog.BlogPO.toDomainModel",
			"study.huhao.demo.adapters.outbound.persistence.blog.BlogPO.of",
			"study.huhao.demo.infrastructure.persistence.blog.BlogPO.convertDomain"
		]
	},
	"ServiceSummary": {
		"LifecycleMap": null,
		"ReturnTypeMap": {
			"BookRepresentaion": [
				"com.phodal.pholedge.book.BookService.getBookById",
				"com.phodal.pholedge.book.BookService.updateBook"
			]
		},
		"RelatedMethod": null
	},
	"UtilsSummary": {},
	"Summary": {
		"UtilsCount": 1,
		"ClassCount": 64,
		"MethodCount": 161,
		"StaticMethodCount": 19
	}
}
P
Phodal Huang 已提交
365 366
```

P
Phodal Huang 已提交
367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390
### Todo

```
coca todo
```

results:

```
+------------+--------------+--------------------------------+---------------------------------------------------+-------+
|    DATE    |    AUTHOR    |            MESSAGES            |                     FILENAME                      | LINE  |
+------------+--------------+--------------------------------+---------------------------------------------------+-------+
| 2019-12-19 | Phodal Huang | 支持 interface 在同一个包内    | core/adapter/api/JavaApiListener.go               |   200 |
| 2019-12-21 | Phodal Huang | 处理链试调用                   | core/adapter/bs/BadSmellListener.go               |   305 |
| 2019-12-18 | Phodal Huang | update this reflect            | core/adapter/bs/BadSmellListener.go               |   363 |
| 2019-12-15 | Phodal Huang | update for array               | core/adapter/bs/BadSmellListener.go               |   388 |
| 2019-12-24 | Phodal Huang | 支持依赖注入                   | core/adapter/call/JavaCallListener.go             |   108 |
| 2019-12-24 | Phodal Huang | add inner creator examples     | core/adapter/call/JavaCallListener.go             |   209 |
| 2019-12-24 | Phodal Huang | add inner creator examples     | core/adapter/call/JavaCallListener.go             |   215 |
| 2019-12-24 | Phodal Huang |                                | core/adapter/call/JavaCallListener.go             |   270 |
| 2019-12-20 | Phodal Huang | 处理链试调用                   | core/adapter/call/JavaCallListener.go             |   324 |
+------------+--------------+--------------------------------+---------------------------------------------------+-------+
```

P
Phodal Huang 已提交
391 392 393 394 395 396 397 398 399
### Suggest

```
coca suggest
```

results:

```
P
Phodal Huang 已提交
400 401 402 403 404 405 406 407
+--------+------------------+--------------------------------+
| CLASS  |     PATTERN      |             REASON             |
+--------+------------------+--------------------------------+
| Insect | factory          | too many constructor           |
| Bee    | factory, builder | complex constructor, too       |
|        |                  | many constructor, too many     |
|        |                  | parameters                     |
+--------+------------------+--------------------------------+
P
Phodal Huang 已提交
408
```
P
Phodal Huang 已提交
409

P
Phodal Huang 已提交
410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
### Test Bad Smells

```
coca tbs
``` 

results

```json
[
	{
		"FileName": "_fixtures/tbs/code/EmptyTest.java",
		"Type": "EmptyTest",
		"Description": "",
		"Line": 0
	},
	{
		"FileName": "_fixtures/tbs/code/IgnoreTest.java",
		"Type": "IgnoreTest",
		"Description": "",
		"Line": 0
	}
]
```

P
Phodal Huang 已提交
435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489
## Todo

 - [x] bad smell support
   - [x] longParameterList
   - [x] longMethod
   - [x] repeatedSwitches
   - [x] complexIf
   - [x] largeClass
   - [x] refusedBequest
   - [x] dataClass
   - [x] sort method size
 - [x] CLOC
 - [x] API Visualization
    - [x] Spring Support
    - [x] @Service Support
    - [x] API Call Size
 - [x] Git
    - [x] Revs Counts
    - [x] Summary
 - [x] Concept
    - [x] words NLP        
 - [x] call & rcall graph
    - [x] Count Refs
 - [x] AutoRefactor
   - [x] remove unused
   - [x] move files
 - [x] Evaluate
   - [x] nullable count
   - [x] static count
   - [x] method num /length count
 - [x] Todo Summary
    - [x] Todo with History & Author   
 - [x] Show all todos and history
 - [ ] Suggest API for Design Patterns
   - [x] factory pattern
   - [x] strategy 
   - [x] builder
   - [ ] cycle-deps -> adapter / agency
 - [ ] Docs
    - [ ] Lifecycle for new projects: evaluate (cloc, bad smell, api, git, todo) -> design -> patterns (suggest) -> refactoring ()
 -  Evaluate API
    - [x] Average Method Length
    - [x] Average Class Method Count
 - Date Collections
    - [ ] monolithic
    - [ ] microservice 
    - [ ] big data
 - Tests
    - [ ] Testable?
    - [ ] Test badsmell
        - [x] Test bad smell list [https://testsmells.github.io/pages/testsmells.html]
 - Arch
    - [x] Architecture Visualization
    - [ ] Architecture Guard
      - [ ] DSL Design
P
Phodal Huang 已提交
490 491 492 493 494

Tech Debt

 - Duplicate Code
   - cmd/ -> user builder to refactoring
P
Phodal Huang 已提交
495

P
Phodal HUANG 已提交
496 497
## Dev

P
Phodal Huang 已提交
498
Install Go
P
Phodal HUANG 已提交
499 500 501 502 503

```bash
brew install go
```

P
Phodal Huang 已提交
504
Env
P
Phodal HUANG 已提交
505 506 507 508 509 510 511

```bash
export GOROOT=/usr/local/opt/go/libexec
export GOPATH=$HOME/.go
export PATH=$PATH:$GOROOT/bin:$GOPATH/bin
```

P
Phodal Huang 已提交
512
clone
P
Phodal HUANG 已提交
513 514

```
P
Phodal Huang 已提交
515
git clone https://github.com/phodal/coca
P
Phodal HUANG 已提交
516 517
```

P
Phodal Huang 已提交
518
Test Frameworks
P
Phodal HUANG 已提交
519 520 521 522

```
go get github.com/onsi/ginkgo
go get github.com/onsi/gomega
P
Phodal HUANG 已提交
523 524
```

P
Phodal Huang 已提交
525 526 527
License
---

P
Phodal Huang 已提交
528 529 530 531
Arch based on [Tequila](https://github.com/newlee/tequila)

Git Analysis inspired by [Code Maat](https://github.com/adamtornhill/code-maat)

P
Phodal Huang 已提交
532 533
Test bad smells inspired by [Test Smell Examples](https://testsmells.github.io/pages/testsmellexamples.html)

P
Phodal Huang 已提交
534 535
[![Phodal's Idea](http://brand.phodal.com/shields/idea-small.svg)](http://ideas.phodal.com/)

P
Phodal Huang 已提交
536
@ 2019 A [Phodal Huang](https://www.phodal.com)'s [Idea](http://github.com/phodal/ideas).  This code is distributed under the MPL license. See `LICENSE` in this directory.